-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store error logs for each import job #1038
Conversation
@girishpanchal30 I think we need a way to limit this and store only the last ones, i.e let's say 200 logs. @vytisbulkevicius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We can limit the items as Marius mentioned, and maybe improve the styling a bit so it looks more readable. Also, they don't need to be red. They're not just errors.
@HardeepAsrani I've applied both changes. |
@girishpanchal30 please check the conflict here |
7d5875a
to
257910c
Compare
257910c
to
dfe1d1f
Compare
@vytisbulkevicius Resolved |
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Adds error log storing features.
Will affect visual aspect of the product
Yes
Screenshots
Test instructions
Option 1:
Activate a lower license plan and use higher plan magic tags in the import job.
Option 2:
Add the following code snippet to allow other error types:
Users can disable the error storing feature by adding the following code snippet:
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/701