Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store error logs for each import job #1038

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Dec 19, 2024

Summary

Adds error log storing features.

Will affect visual aspect of the product

Yes

Screenshots

image

Test instructions

Option 1:
Activate a lower license plan and use higher plan magic tags in the import job.

Option 2:
Add the following code snippet to allow other error types:

add_filter(
	'feedzy_allowed_store_log_types',
	function ( $types ) {
		$types[] = 'debug'; // info, warn
		return $types;
	}
);

Users can disable the error storing feature by adding the following code snippet:

add_filter( 'feedzy_skip_store_error_logs', '__return_true' );

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/701

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 19, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 19, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 19, 2024

Plugin build for dfe1d1f is ready 🛎️!

@selul
Copy link
Contributor

selul commented Dec 19, 2024

@girishpanchal30 I think we need a way to limit this and store only the last ones, i.e let's say 200 logs. @vytisbulkevicius

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can limit the items as Marius mentioned, and maybe improve the styling a bit so it looks more readable. Also, they don't need to be red. They're not just errors.

@girishpanchal30
Copy link
Contributor Author

@HardeepAsrani I've applied both changes.

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30 please check the conflict here

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius Resolved

@vytisbulkevicius vytisbulkevicius merged commit 6082114 into development Dec 27, 2024
8 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/pro/701 branch December 27, 2024 12:45
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants